Reintroduce postgres support #560
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justjanne
changed the title
This was referenced Jun 14, 2022
|
@haiwen I’d like to request a review for this PR and the related PRs. If you’d find time to take a look at these, that’d be great! I know that even with these patches the PE won’t support postgres, but it’d be great to have at least postgres support in the CE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Short
REPLACE INTOstatements to support postgres properly as wellRelated
haiwen/seafdav#66
haiwen/seahub#5196
Rationale
Many users (me included) use Seafile with PostgreSQL databases. Seafile has supported Postgres databases with small patches for many years, but during a recent db backend rewrite that functionality got removed. My own deployment has been stuck on 7.0, with no update in sight.
Due to that, I’ve decided to implement Postgres support back into Seafile. If it doesn’t get merged, I’ll have to maintain a custom fork with downstream patches, which I’d like to avoid.